search

telekom-mms / ansible-collection-icinga-director

An Ansible collection that contains modules to change objects in Icinga 2 using the director API.
GNU General Public License v3.0
81 stars 30 forks source link

[Bug] ansible_icinga: option icinga_notifications.time_period has invalid type 'strod' #259

Closed felixfontein closed 2 months ago

felixfontein commented 2 months ago

Description

It should probably be 'str', not 'strod'.

Reproduction steps

-

Current Behavior

-

Expected Behavior

-

Additional information

You might want to add a docs linting step to CI: antsibull-docs lint-collection-docs . --skip-rstcheck --plugin-docs reports this.

(You can also see it here: https://docs.ansible.com/ansible/devel/collections/telekom_mms/icinga_director/ansible_icinga_role.html - but having that reported in CI is probably more useful :) )

rndmh3ro commented 2 months ago

thanks felix, fixed by #260

rndmh3ro commented 2 months ago

Let's add antsibull-docs lint-collection-docs . --skip-rstcheck --plugin-docs to the tests.

felixfontein commented 2 months ago

If you need an inspriation: https://github.com/ansible-collections/collection_template/blob/main/.github/workflows/extra-docs-linting.yml ;)