telekom / nlu-bridge

MIT License
4 stars 5 forks source link

Improve naming #18

Closed kengelbrecht closed 2 years ago

kengelbrecht commented 2 years ago

Optimierung von Namen

Reasoning behind the vendor name changes:

kengelbrecht commented 2 years ago

Created branch feature/better_names

kengelbrecht commented 2 years ago

Added function nlubridge.concat(dataset_list) analoguous to pandas.concat(). Added NluDataset method joined = NluDataset.join(other_dataset) analoguous to pandas.DataFrame.join(). Added DeprecationWarning for NluDataset method NluDataset.from_joined; should use one of the new methods (most likely concat() in this case)

kengelbrecht commented 2 years ago

to_json/from_json already works correctly. Added a test to assert from_json works with the string returned by to_json(path=None).

kengelbrecht commented 2 years ago

Changes as outlined in the description merged to develop with commit 9e93bc8119a689db97961916f70f83bac5a78657