telekom / scale

Scale is the digital design system for Telekom products and experiences.
https://telekom.github.io/scale/
Other
374 stars 82 forks source link

"@telekom/scale-components-react" is outdated and does not support new scale components #1960

Closed tischrei closed 1 year ago

tischrei commented 1 year ago

Scale Version "@telekom/scale-components": "^3.0.0-beta.134", "@telekom/scale-components-react": "^3.0.0-beta.56"

Framework and version "react": "18.2.0", "react-dom": "18.2.0", "next": "^13.4.4",

Current Behavior The newly created scale components cannot be used as intended. Elements like scale chip are not supported. The wrapper is outdated. It would be nice if the wrapper would be updated in the same pipeline as the components are updated. For instance ScaleChip is not supported.

Expected Behavior All scale components should be supported.

felix-ico commented 1 year ago

Hi @tischrei, every time a new scale-components version is released the scale-components-react version gets bumped as well. Could you please try to set both dependencies to the same version (beta.134) and see if that solves your issue?

SebastianGode commented 1 year ago

Hey @felix-ico I think the underlying issue is a wrong documentation. The documentation states to install:

@telekom/scale-components@next

and for the wrapper package

@telekom/scale-components-react

This will result in having an outdated wrapper but an up-to-date component package installed. And that will result in the error mentioned above. So please have a look at the documentation and update it. We likely want to have @telekom/scale-components-react@next installed. Also please remove the other examples for the wrapper packages as e.g. reactify-wc isn't compatible with current react versions anymore.

tischrei commented 1 year ago

I have followed the instructions in the scale docs and failed. So the proposed documentation update in the following commit: https://github.com/telekom/scale/commit/37e3883e16c236982894dd79c31137469ddd1505 specifies the proper installation package.