telekom / testerra

Testerra is an integrated framework for automating tests for (web) applications.

https://docs.testerra.io/

Apache License 2.0

27 stars 15 forks source link

Update to Selenium 4.18 - Replace EventFiringWebDriver #381

Closed martingrossmann closed 8 months ago

martingrossmann commented 10 months ago

Description

The listener EventFiringWebDriver is deprecated and was also removed in current Selenium trunk (https://github.com/SeleniumHQ/selenium/pull/13200).

Selenium now provides EventFiringDecorator and WebDriverListener. This change includes an update to Selenium 4.18.1.

There is still an open PR which adds some more methods to WebDriverListener we want to use:

[x] https://github.com/SeleniumHQ/selenium/pull/13210
[x] Selenium ~~4.17~~ 4.18 released

Other ToDos:

[x] Check for removing unwrap methods, maybe not needed any more --> still needed to get orginal driver from decorated one.
[x] Rename all eventFiringWebdriver variables to webDriver
[x] Cleanup

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules