search

telenordigital / connect-android-sdk

Android SDK for CONNECT ID
https://telenordigital.github.io/id-docs.telenordigital.com/
Other
16 stars 14 forks source link

Update to Google Play Services 15.0.1 #126

Closed simonnorberg closed 6 years ago

simonnorberg commented 6 years ago

Google Play Services 8.3 was added in #107

Version 8.3 dates back to November 2015. https://developers.google.com/android/guides/releases#november_2015_-_version_83

Is there a reason for using this old version?

In 15.0.1 the AdvertisingIdClient class has been moved from play-services-basement to play-services-ads-identifier. The GoogleApiAvailability class has been moved to play-services-base.

This change only adds 720 methods according to Dexcount 👍 Version 8.3:

Total methods in id-example-debug.apk: 13099 (19.99% used)

Version 15.0.1:

Total methods in id-example-debug.apk: 13819 (21.09% used)

Also, ProGuard rules are included in the library so no need to add them manually. See https://developers.google.com/android/guides/setup

jorunfa commented 6 years ago

I think it was because of the advertising id, and I didn't realise at the time that it wasn't the latest version. Seems good, I'll just check it out quickly and then I think we can merge it.

jorunfa commented 6 years ago

Looks very good - thanks! 🕺 I guess we could move the ProGuard rules to the SDK as well, instead of just having them in the example app, but that's not for this issue.