search

telenordigital / connect-android-sdk

Android SDK for CONNECT ID
https://telenordigital.github.io/id-docs.telenordigital.com/
Other
16 stars 14 forks source link

Add Instant verification #136

Closed jorunfa closed 5 years ago

jorunfa commented 5 years ago
  1. This change is huge. Sorry about that.
  2. There is lots of non-obvious moving of existing code. (ConnectLoginButton -> ConnectLoginButtonWithoutProgressBar. The ConnectLoginButton is new.)
  3. Lots of existing code have lacklustre testing. A fix for this has not been prioritised.
  4. Quite a bit of manual testing have been done.
  5. Known missing: Flag or way to disable the feature.
jorunfa commented 5 years ago

@froeseth: I think all comments have been addressed somehow, if you have the time to look the responses over.

jorunfa commented 5 years ago

@froeseth, fyi I added 36ef984 and 06e0f86 before merging.