search

teleological / redmine_stealth

Sometimes sneaky is good. This plugin works like a mute button for Redmine notification emails.
http://teleological.github.com/redmine_stealth
GNU General Public License v2.0
31 stars 35 forks source link

Make it much more visible that we are in stealth mode #1

Closed that0n3guy closed 12 years ago

that0n3guy commented 13 years ago

Hey, awesome plugin. One thing though is that we should probably have a more eyecatching visual indicator that shows that we are in stealth mode so we don't forget.

Maybe a simple 10px red bar above the site... super simple and would work w/ any theme. Everytime you load a page you would see this red bar and know your in stealth mode.

DS-BSZ commented 12 years ago

+1

teleological commented 12 years ago

I think this is a good idea -- I sometimes forget that I'm in stealth mode and end up having to create follow-up emails. Would you be able to submit a pull request along the lines that you describe?

teleological commented 12 years ago

It looks like this person has a similar idea:

https://gist.github.com/1025146/77e5c59d138948ebc654b0f7c82fdcaa620cccd0

cs42 commented 12 years ago

This has at least one big problem: this code tests for the string which is internationalized, thus you would have to test for each language => not feasible

A better solution would be to add a class _stealthon and _stealthoff to the HTML, preferably to the <li> of the menu entry or even better to the <ul> of the menu. There I'm failing currently...

DS-BSZ commented 12 years ago

It would be even better, if the highlighting was right where you enter your text, like e.g. a frame around the text box, or an indicator next to the OK button, when you update a ticket, etc.

cs42 commented 12 years ago

Actually the best would be a class=stealth_on on the body of the page. All styling can then be done by the user. I just don't know how to do that...

kfischer commented 12 years ago

I think a class in the body tag is a great idea. We could style the page in a way that would make it very hard to miss that one is working in stealth mode and by this prevent a lot of problems from happening.

cs42 commented 12 years ago

OK, I have a something on my fork: https://github.com/cs42/redmine-stealth-plugin/commit/d50e21982a69a3f242c0fd72f13c623e6a1d7190

This is not completely functional yet, as it doesn't set this class on clicking but only on loading the page. Thus you'll need to reload the page currently to see the changes.

teleological commented 12 years ago

This was fixed by Carsten's patch, version 0.3.0.