teleological / redmine_stealth

Sometimes sneaky is good. This plugin works like a mute button for Redmine notification emails.
http://teleological.github.com/redmine_stealth
GNU General Public License v2.0
31 stars 35 forks source link

link_to_remote #18

Closed jrencz closed 11 years ago

jrencz commented 12 years ago

this helper is removed in Rails 3. File lib/redmine_menu_manager_extensions.rb was last time updated for 0.4.0 During install process on Redmine 2.0.3.devel I got error.

xadh00m commented 11 years ago

I´ve tested the stealth plugin on the latest redmine 1.2.1. The same error occurs here.

Other plugins suffer the same issues e.g. here: https://bitbucket.org/akiko_pusu/redmine_issue_templates/issue/13/redmine-210-problems-link_to_remote

A possible fix using "preview_link" instead is used here: https://github.com/amartel/redmine_meetings/pull/3/files

Any chance that the plugin will become compatible soon?

teleological commented 11 years ago

Looks like this problem is due to Redmine 2.1 switching from Prototype to jQuery:

http://www.redmine.org/issues/11445

Shouldn't be too hard to make it work with either. Looking at it now.

teleological commented 11 years ago

Fixed in v0.6.0

R-i-c-k-y commented 11 years ago

why did you close this issue? the code in v.0.6.0 (File lib/redmine_menu_manager_extensions.rb) i still

[...] module MenuHelper

  def render_single_menu_node_with_remote(item, caption, url, is_sel)
    if remote_options = item.remote_options
      non_html_options = remote_options.kind_of?(Hash) ?
        remote_options.reverse_merge(:url => url) : { :url => url }
        link_to_remote(h(caption),
                    non_html_options,
                    item.html_options(:selected => is_sel))

[...]