Closed dwisiswant0 closed 3 months ago
decisions:
getListenAddr
? well after putting it through some benchmarking, I saw it was doing 3 allocs per op w/o any caching. fetching local addresses was turning out to be a bit of a performance hog, so i figured caching would smooth (cut down that overhead) things out and make everything run way more efficiently.Options.Development
value does NOT really have any downsides. :shrug:
Attention: Patch coverage is 92.85714%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 78.64%. Comparing base (
20b5e7c
) to head (18f804e
). Report is 5 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
utils.go | 90.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
IMPORTANT: Please do not create a PR without creating an issue first!
(Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request).
Summary
feat(teler): add
listen_addr
&caller
fields in the logProposed of changes
This PR fixes/implements the following bugs/features:
How has this been tested?
Proof:
Closing issues
Fixes #
Checklist:
make lint
).