search

telerik / kendo-angular-messages

Localization Messages - Kendo UI for Angular
https://www.telerik.com/kendo-angular-ui/components/globalization/localization/
Other
9 stars 46 forks source link

Missing some translations context #155

Open MLefebvreICO opened 3 years ago

MLefebvreICO commented 3 years ago

Hi there,

Just noticed this is missing some translations context like the kendo jQuery equivalent 😐

Everything that can be visible to the users(labels, title attributes, etc..) must use the translations else we need to manually go edit them on runtime which is not really friendly ..

We don't use a lot of kendo-angular controls for now as we are making the switch from AngularJS/KendoUI to Angular/KendoAngular, but right now we use the editor with some options and I can already see that the insertTable tool has a text on the bottom (Create a table, Create a 4x4 table, etc..) that is not available to translate ..

image

Coming from AngularJS where we had to "hack" multiple usecases like this, I'm sure it's not the only place it's not done, so please integrate them into the translation 🙏

Thanks !

MLefebvreICO commented 3 years ago

This looks like it's an issue for a lot of controls.. 😐

Here on the ColorPicker, there's no translation context for the no color and for the Drag title...

image

I'm pretty sure ARIA fields are not using translations too.

Can we get feedback on this ?

Kendo is supposed to be easily used in other languages, but right now it's really not the case, we have to use hacks everywhere to fix missing translation contexts 😐

Raisolution commented 3 years ago

Hi @MLefebvreICO

We have recently added messages for the ColorPicker and ColorGradient components https://github.com/telerik/kendo-angular-messages/tree/develop/messages/colorpicker which will also be supported out of the box in the upcoming version of the kendo-angular-inputs package.

Adding the missing Editor messages is also in our development plans, but there is no specific date I could provide for them.

MLefebvreICO commented 3 years ago

@Raisolution I appreciate the answer.

However, I checked the ColorPicker's message and there's no message for the no color and I'm pretty sure the same goes for a lot of components.

We are coming from Kendo jQuery and there was a lot of missing translation contexts which looks like it's gonna be the case again in the Angular version.

I think hardcoded text/attributes should be blocked from being merge into any kendo package to avoid missing translation context

Raisolution commented 3 years ago

The hexInputPlaceholder message will be applied to the input question

https://github.com/telerik/kendo-angular-messages/blob/develop/messages/colorpicker/colorpicker.en-US.yml#L13

Thank you for the feedback. We are striving to localize as most of the messages and label attributes as possible, while taking the accessibility into account.