Closed nadavsinai-philips closed 2 years ago
@yanmariomenev any comment on this ?
The custom prosemirror-tables-ts package is no longer in use and we reverted to prosemirror-tables in v. 1.9.2 of the @progress/kendo-editor-common package. Latest versions of the @progress/kendo-angular-editor package already use the updated common package too.
We want to use the very common and very useful
jest-prosemirror
testing library to test plugins we develop this allows to quickly create editors and use custom matchers which compare documents etc.Due to your modified prosemirror-tables package - prosemirror-tables-ts - which is used by
@progres/kendo-angular-editor
inplace ofprosemirror-tables
a fatal error is thrown just by importing your lib andjest-prosemirror
in the same filethe reason is that in line 283 of prosemirror-tables there is the following side-effect
this modified the state of the (shared) prosemirror-state Selection class which throws when the 2nd call arrives on the same ID
To Reproduce Steps to reproduce the behavior:
(really any code that imports from both libraries)
Expected behavior ability to test with jest-prosemirror as the rest of the community
Browser