telerik / kendo-react

Issue tracker - KendoReact http://www.telerik.com/kendo-react-ui/
https://kendo-react-teal.vercel.app
Other
212 stars 36 forks source link

Grid with custom cells with expensive calculations doesn't fire onPageChange sometimes (virtual scrolling) #709

Open alpavlove opened 4 years ago

alpavlove commented 4 years ago

I'm submitting a...

Current behavior

I have the grid set up with a custom cell that has some expensive calculation performed when the cell component init. Usually, when I do scroll it takes some time to be rendered, that's OK. But sometimes I notice the grid doesn't call onPageChange method and the page becomes blank

Expected behavior

It should always perform onPageChange

Minimal reproduction of the problem with instructions

I created an example of that. It quite difficult reproduce, although In my real set up I reproduce it more ofter. So I recorded a screencast. Watch it from the 30th second. You can see sometimes it's stucking until I do scroll again https://take.ms/mXO4h https://stackblitz.com/edit/react-6dfm1k?devtoolsheight=33&file=app/main.jsx

Environment

Package versions:

├── @bookedby/assets-fonts@1.0.1
├── @bookedby/fontawesome-pro@5.12.0
├── @progress/kendo-data-query@1.5.4
├── @progress/kendo-drawing@1.8.1
├── @progress/kendo-react-animation@3.15.0
├── @progress/kendo-react-data-tools@3.15.0
├── @progress/kendo-react-dateinputs@3.15.0
├── @progress/kendo-react-dialogs@3.15.0
├── @progress/kendo-react-dropdowns@3.15.0
├── @progress/kendo-react-grid@3.15.0
├── @progress/kendo-react-inputs@3.15.0
├── @progress/kendo-react-intl@3.15.0
├── @progress/kendo-theme-bootstrap@4.18.0
├── @testing-library/jest-dom@4.2.4
├── @testing-library/react@9.5.0
├── @testing-library/user-event@7.2.1
├── @types/classnames@2.2.10
├── @types/jest@24.9.1
├── @types/lodash@4.14.159
├── @types/luxon@1.24.3
├── @types/node@12.12.48
├── @types/react@16.9.41
├── @types/react-dom@16.9.8
├── UNMET PEER DEPENDENCY bootstrap@^4.5.0
├── classnames@2.2.6
├── immer@7.0.7
├── lodash@4.17.19
├── luxon@1.24.1
├── node-sass@4.14.1
├── react@16.13.1
├── react-device-detect@1.13.1
├── react-dom@16.13.1
├── react-router-dom@5.2.0
├── react-scripts@3.4.1
├── react-use@15.3.3
├── reakit@1.1.2
├── reselect@4.0.0
├── sass-rem@2.0.1
├── source-map-explorer@2.4.2
├── typesafe-actions@5.1.0
├── typescript@3.7.5
└── uuid@8.3.0

Browser:

System:

Nodios commented 3 years ago

@simonssspirit any plans for this?

francisu commented 3 years ago

I understand from this thread: https://www.telerik.com/forums/cells-remounting-while-scrolling-a-virtualized-grid there is a PR that is supposed to fix this. Is there any status on that?

kdikov82 commented 1 year ago

Related with https://github.com/telerik/kendo-react/issues/1270