telerik / kendo-theme-bootstrap

Kendo UI theme, based on Bootstrap v4
Other
25 stars 14 forks source link

Update bootstrap dependency to v4.0.0 #360

Closed joneff closed 6 years ago

joneff commented 6 years ago

Update bootstrap dependency to v4.0.0

Alerts (KendoUI Notification)

Button

Forms (KendoUI inputs and pickers)

Nav (KendoUI Tabstrip)

Navbar (KendoUI Menu)

Pagination (KendoUI Pager)

Tooltip

Function

Variables

Note: those aren't necessarily issues. Rather, they are things that need to be checked.

joneff commented 6 years ago

@gyoshev the only real issue, thus far is that there is the notion of dismissible notification with a dedicated class name. We could open a new FR for KendoUI and the flavours for that

The rest should be pretty straightforward.

/cc @ivanchev

gyoshev commented 6 years ago

Isn't that something specific to the bootstrap layout? I could not follow how this affects the Kendo UI components, i.e. the notification styling.

joneff commented 6 years ago

It doesn't affect them really. It just seems like a nice idea to have this class name, so we can provide extra padding on the far side of notification. The difference may be visible in multiline notifications, but that's about it.