telerik / kendo-themes

Monorepo for SASS-based Kendo UI themes
149 stars 71 forks source link

Unexpected dark color of primary button and selected button in button group since 5.8.2-dev.5 #4041

Closed Dimitar-Goshev closed 1 year ago

Dimitar-Goshev commented 2 years ago

Describe the bug A clear and concise description of what the bug is.

To reproduce Steps to reproduce the behavior:

  1. Use the following setup https://dojo.telerik.com/@Dimitar-Goshev/uZiyARas and reference the bootstrap-main-dark swatch from 5.8.2-dev.5

Actual behavior The text color of selected buttongroup button is dark as on the screenshot below

Expected behavior The text color of selected buttongroup button is lights as on the above Dojo

Screenshots image

Affected package (please remove the unneeded items)

Affected suites (please remove the unneeded items)

Affected browsers (please remove the unneeded items)

Build system information (please remove the unneeded items)

joneff commented 1 year ago

While it may seem counter intuitive, the reported issue is not a bug, but rather a statement: indeed the contrast color of that particular shade of blue is black, rather than white.

That's not to say we are leaving the issue like that, or we are not targeting it -- quite the contrary -- we are! While implementing a fix regarding dark themes in general, we took the opportunity to transfer the logic of Bootstrap 5.3.0-alpha for dark themes into our.

It's not perfect yet, but that's still an alpha... Sill, the improvement targets this issue.