telerik / kendo-themes

Monorepo for SASS-based Kendo UI themes
148 stars 68 forks source link

[Grid] Broken styles on latest version #4238

Open BaHXeLiSiHg opened 1 year ago

BaHXeLiSiHg commented 1 year ago

Describe the bug

Facing styling problems, after update to the latest version of grid + theming packages.

$kendo-color-primary: blue;
$kendo-base-bg: white;

@import "@progress/kendo-theme-material/scss/variables";
@import "@progress/kendo-theme-material/scss/grid/index";

1) Group footer borders are doubled (i think it's related to grids css). 2) Disabled color of navigation buttons was overridden by "@progress/kendo-theme-default/scss/pager/_layout.scss" (line 70).

image

3) Text and background colors of paging buttons was overridden by "@progress/kendo-theme-default/scss/pager/_layout.scss" (line 59).

image

Comparison screenshot of theming version 6.0.3

image

Comparison screenshot of theming version 5.12.0

image

To Reproduce

Update to latest packages version.

"@progress/kendo-angular-grid": "11.0.0",
"@progress/kendo-theme-material": "6.0.3"

Expected behavior

1) Group footer borders not doubled. 2) Disabled color of navigation buttons not overridden. 3) Text and background colors of paging buttons applied from defined variables.

PaskalevStoyan commented 1 year ago

Transfering to the Kendo Themes as these issues are related to the Themes.

joneff commented 1 year ago

@PaskalevStoyan it's partially in the themes, partially the angular implementation, which differs from the reference rendering. k-pager-numbers-wrap should also contain the previous and next buttons. Still, that's not the only issue.

@BaHXeLiSiHg acknowledged. We'll take a closer look at those styles. Since we introduced the theme colors for buttons, there should not be styles that override them.

joneff commented 1 year ago

@BaHXeLiSiHg I thought this seemed familiar. We are making some improvements in other areas, when we noticed class names were not correctly applied. 2cb7f939cc2342d4a6cbd6a54bd3201295556b70 targets part of the issue.