telerik / kendo-themes

Monorepo for SASS-based Kendo UI themes
149 stars 71 forks source link

Html specs corrections 5 #5227

Open TeyaVes opened 2 weeks ago

TeyaVes commented 2 weeks ago

targets: https://github.com/telerik/kendo-themes-private/issues/246

This PR targets the following items from the related issue:

Toolbar

Map

Expansion panel / Expander

Switch

TabStrip

CheckBox

ImageEditor

DateTimePicker, others

inikolova commented 1 week ago

Most of the things look OK :) A small adjustment is needed in the ImageEditor - there is width 241px set to .k-imageeditor-action-pane - this width should be increased, as in the Material and Fluent themes there is a horizontal scrollbar.

TeyaVes commented 1 week ago

As discussed at the FE & Design sync, I'll fix the width of the ImageEditor Pane for now and apply any further changes once the design has been revised. However, I'll do so in a separate PR for a better clarity: https://github.com/telerik/kendo-themes/pull/5238

TeyaVes commented 6 days ago

Looks okay overall, I am just wondering about two things:

  1. If we are removing the k-tab-on-top class, shouldn't we remove it from spreadsheet-jquery.tsx as well? And if it is an obsolete class should't we delete it?
  2. Are we okay with the difference in the ImageEditor label font weight in Fluent? I know that this is the correct checkbox position, but still.
  1. I've removed the k-tab-on-top class from the styles and the specs.

  2. I think that we should leave the checkbox with label with the normal font weight in Fluent - following the logic only the formfield labels are bold.