Open TeyaVes opened 2 weeks ago
Most of the things look OK :) A small adjustment is needed in the ImageEditor - there is width 241px set to .k-imageeditor-action-pane - this width should be increased, as in the Material and Fluent themes there is a horizontal scrollbar.
As discussed at the FE & Design sync, I'll fix the width of the ImageEditor Pane for now and apply any further changes once the design has been revised. However, I'll do so in a separate PR for a better clarity: https://github.com/telerik/kendo-themes/pull/5238
Looks okay overall, I am just wondering about two things:
- If we are removing the
k-tab-on-top
class, shouldn't we remove it fromspreadsheet-jquery.tsx
as well? And if it is an obsolete class should't we delete it?- Are we okay with the difference in the ImageEditor label font weight in Fluent? I know that this is the correct checkbox position, but still.
I've removed the k-tab-on-top class from the styles and the specs.
I think that we should leave the checkbox with label with the normal font weight in Fluent - following the logic only the formfield labels are bold.
targets: https://github.com/telerik/kendo-themes-private/issues/246
This PR targets the following items from the related issue:
Toolbar
Map
Expansion panel / Expander
Switch
TabStrip
CheckBox
ImageEditor
DateTimePicker, others