telerik / kendo-themes

Monorepo for SASS-based Kendo UI themes
148 stars 68 forks source link

Summary task which has only one Milestone task does not render its milestone visualization in the Timeline #919

Open veselints opened 4 years ago

veselints commented 4 years ago

Describe the bug A Summary task which has only one Milestone task does not render its milestone visualization in the Timeline.

To reproduce Run the following Dojo: https://dojo.telerik.com/UVuVAcoG/3 The summary (parent) task is not visualized in the Timeline.

Expected behavior The summary (parent) task should be visualized in the Timeline.

Affected package (please provide)

Affected suites (please provide)

Affected browsers (please provide) ALL

joneff commented 4 years ago

Considering the summary has no "horns" and there are not task its width is 0, how does an empty summary look like?

veselints commented 4 years ago

Considering the summary has no "horns" and there are not task its width is 0, how does an empty summary look like?

Consult the LESS themes, where the parent is rendered just like the Milestone: https://dojo.telerik.com/uxabOSoK

joneff commented 4 years ago

Consult the LESS themes, where the parent is rendered just like the Milestone: https://dojo.telerik.com/uxabOSoK

Because they have "horns" -- the small triangle tings at the end of the line. Neither of the sass themes has them. I guess we'll have to add them... @ivelina-penkova thoughts?

ivelina-penkova commented 4 years ago

I'm fine adding the "horns" to the sass themes and I'll update the design files to be consistent.