search

telerik / kendo-ui-core

An HTML5, jQuery-based widget library for building modern web apps.
http://www.telerik.com/kendo-ui
Other
2.53k stars 1.91k forks source link

Spreadsheet custom editor button is not visible in specific frozen columns scenarios #5097

Open veselints opened 5 years ago

veselints commented 5 years ago

Bug report

There are two cases in which the issue will be present. Both of them are reated to a case where only one column is not frozen or only one column is frozen:

Case 1:

Spreadsheet custom editor is configured for a cell in the last column of the sheet and the previous column is frozen.

Case 2:

Spreadsheet custom editor is configured for a cell in the first column of the sheet and only that column is frozen.

Related to #3862 and #3105

Reproduction of the problem

Case 1:

  1. Open the following Dojo: https://dojo.telerik.com/ozOyEluj/4
  2. Select the B1 cell
  3. The editor button will not be displayed.

Case 2:

  1. Open the following Dojo: https://dojo.telerik.com/ozOyEluj/8
  2. Select the B1 cell
  3. The editor button will not be displayed.

Case 3 (when only one column is present in the Spreadsheet):

  1. Open the following Dojo: https://dojo.telerik.com/ozOyEluj/12
  2. Select the A1 cell
  3. The editor button will not be displayed.

Current behavior

The editor icon is not visible

Expected/desired behavior

The icon should be visible

Environment

veselints commented 5 years ago

Also reported in 1413349

veselints commented 4 years ago

Also discussed in: https://supportheroes.telerik.com/ticket/1364441

mishoo commented 3 years ago

I refactored it to render the button inside the cell:

image

This has the advantage that it'll show up in all situations. We add padding-right so that the button doesn't overlap the content for right-aligned cells:

image

However, when the cell is not wide enough, we don't have much choice:

image

Since the button only shows up while the cell is selected, I hope this won't be a problem. Available on branch spreadsheet-custom-editor-button as I wasn't sure the new design is acceptable. Please let me know if I can merge it.

mparvanov commented 3 years ago

The button is shown behind the cells with SASS themes while looks fine with LESS themes: https://www.screencast.com/t/UoCZ96rt0

mishoo commented 3 years ago

The button is shown behind the cells with SASS themes while looks fine with LESS themes: https://www.screencast.com/t/UoCZ96rt0

This patch should be applied to the SASS themes: https://github.com/telerik/kendo/commit/539d76a30cce38bb61745bb52619340b33b3fa87#diff-6498906e7fc75f73b0b25facadabaa47fed8c2df9f7201e1efae3bb1592eb125