telerik / mobile-cli-lib

Contains common infrastructure for CLIs - mainly AppBuilder, NativeScript, DDB and Proton.
Apache License 2.0
11 stars 10 forks source link

Do not track help command when other command fails #1021

Closed rosen-vladimirov closed 6 years ago

rosen-vladimirov commented 7 years ago

In case any command fails, we execute help command in order to show the help content. This leads to multiple trackings, i.e. - user executes only one command, but in Analytics we see two commands. Instead of executing help command, introduce new method in htmlHelpService, that prints the help to the terminal and call it instead. Use the same method in the help command itself. Rename htmlHelpService to helpService - it has been incorrectly named from the beginning. Remove helpTextPath from staticConfig interface - this property is not used for more than 2 years. Introduce tests for helpService - get the tests from AppBuilder CLI.

KristianDD commented 6 years ago

Looks ok.