telerik / mobile-cli-lib

Contains common infrastructure for CLIs - mainly AppBuilder, NativeScript, DDB and Proton.
Apache License 2.0
11 stars 10 forks source link

Fix livesync issues #898

Closed rosen-vladimirov closed 7 years ago

rosen-vladimirov commented 7 years ago

Fix several missing awaits in LiveSyncServiceBase which caused unexpected behavior during livesync. For example livesync to ION leads to error when adding a file in some cases. Fix gaze to skip node_modules and platforms directories - in the current state, when we are inside Angular project, the node_modules directory contains tens of thousands of files. Gaze starts painfully slow and utilizes 100% of the CPU. So ignore these directories. Fix killing of TypeScript process started with --watch option. It failed with error Cannot read property '_handle' of null. Fix this by passing correct this. When we are inside TypeScript process, we attach to process's SIGINT signal in order to kill TypeScript Watcher. However Node.js decides that we have to handle all other currently living processes on our own. In this particular case, gaze process is also kept alive and pressing Ctrl + C does not kill the livesync process. Fix this by killing gaze process on SIGINT.

In some cases, the handles that we are trying to execute on process exit are failing. Try-catch each execution, so even if one fails, we'll still execute all of the handles.

Fixes http://teampulse.telerik.com/view#item/329354

justcodebuilduser commented 7 years ago

:heart: