Add check in iOS device discovery if platform is Android. - Githubissues

telerik / mobile-cli-lib

Contains common infrastructure for CLIs - mainly AppBuilder, NativeScript, DDB and Proton.

Apache License 2.0

11 stars 10 forks source link

Add check in iOS device discovery if platform is Android. #985

Closed KristianDD closed 7 years ago

KristianDD commented 7 years ago

This PR is part of the resolution of https://github.com/NativeScript/nativescript-cli/issues/2361. The device discovery services didn't check the platform parameter before performing the validations needed for the specified platform.

The resolution is to always pass platform parameter to the device discovery services if specified and add a platform check inside each device discovery service.

justcodebuilduser commented 7 years ago

:broken_heart:

justcodebuilduser commented 7 years ago

:broken_heart:

justcodebuilduser commented 7 years ago

:broken_heart:

justcodebuilduser commented 7 years ago

:broken_heart:

justcodebuilduser commented 7 years ago

:broken_heart:

justcodebuilduser commented 7 years ago

:broken_heart:

justcodebuilduser commented 7 years ago

:broken_heart:

justcodebuilduser commented 7 years ago

:broken_heart:

justcodebuilduser commented 7 years ago

:broken_heart:

justcodebuilduser commented 7 years ago

:broken_heart:

justcodebuilduser commented 7 years ago

:broken_heart:

Plamen5kov commented 7 years ago

Recomendation: Because these options: { shouldReturnImmediateResult: false, platform: platform } are passed on several places, maybe we can do a getDefaultSearchOptions() or something.

justcodebuilduser commented 7 years ago

:broken_heart:

justcodebuilduser commented 7 years ago

:broken_heart: