telescope-browser / telescope

browser for the small internet
https://telescope-browser.org
ISC License
43 stars 1 forks source link

Can't create landlock ruleset #7

Closed sikmir closed 2 years ago

sikmir commented 2 years ago
$ telescope -v
telescope 0.6
$ telescope gemini://gemini.omarpolo.com/
telescope: landlock: Function not implemented
telescope: can't create landlock ruleset
: Function not implemented

OS: Linux

omar-polo commented 2 years ago

I still haven't finished to prepare 0.6 and there are already some bugs :D

I hoped there wasn't any reason to do the checks I'm doing in gmid sandbox.c, but it seems that's the case. It seems that landlock can be enabled at kernel build-time but then disabled. (otherwise the configure script wouldn't have picked up landlock.h and disabled it)

Just for curiosity, what distro are you using and what kernel version?

Thanks!

sikmir commented 2 years ago

Just for curiosity, what distro are you using and what kernel version?

NixOS, kernel 5.10.81.

sikmir commented 2 years ago

It looks like it requires to enable SELinux with kernel parameters lsm=landlock. Not tried yet.

omar-polo commented 2 years ago

Well, telescope should handle also the situation where landlock is present at compile-time but not a runtime I guess. I hoped that landlock was always enabled to be honest, but it doesn't seem the case.

I'm handling the situation, if you have a bit of time I'm gonna ask you in a few minutes to try a pr and then tag 0.6.1 with the fix hopefully! :)

omar-polo commented 2 years ago

I've created #8 with a simple fix, could you please try it with the kernel that has landlock disabled? thanks in advance! :)

omar-polo commented 2 years ago

I've tagged 0.6.1 with this bugfix, in a while I'll upload also the signed tarballs.

Thanks again for reporting!