Fix encoding problem in non-english language in Windows os

I'm using your extension, which has saved me much time.

Everything is fine before I tried to use it when the Markdown file was in a folder with Chinese letter in its name, which means the imagePath below may contain Chinese letter.

private static saveClipboardImageToFileAndGetPath(imagePath, cb: (imagePath: string) => void)

I traced the execution of your extension and found the Chinese part of imagePath became a mess in the callback function of saveClipboardImageToFileAndGetPath:

According to your code, when plplatform === 'win32', it will run the /res/pc.ps1 file with PowerShell. And in the file pc.ps1, the output is exactly the input, without any modification.

param($imagePath)

......

$imagePath

After some search I found this article, which says

When we pipe output data from PowerShell cmdlets into native applications, the output encoding from PowerShell cmdlets is controlled by the $OutputEncoding variable, which is by default set to ASCII

And that's the problem, Chinese letters(and also letters in many other languages) can't be represented in ASCII encoding, so the data.toString() in following code can't get the correct imagePath.

powershell.stdout.on('data', function (data: Buffer) {
    cb(data.toString().trim());
});

AFAIK there's two way to fix the problem:

The first way. Since you don't modify the imagePath in file pc.ps1, the code can be rewritten like this:

powershell.on('exit', function (code, signal) {
    cb(imagePath)
 });
powershell.stdout.on('data', function (data: Buffer) {
    // do nothing
});

The second way. Add a line to adjust the encoding of output. This will set the output of pc.ps1 to UTF-8, which can represent many letters in various language.

param($imagePath)

......

[System.Console]::OutputEncoding=[System.Text.Encoding]::GetEncoding(65001)
$imagePath

Thanks for your work!

telesoho / vscode-markdown-paste-image

Fix encoding problem in non-english language in Windows os #7