teletrace / teletrace

Open-Source Tracing Platform
https://docs.teletrace.io
Apache License 2.0
625 stars 23 forks source link

🐛 Timeline bug #846

Closed adva-cisco closed 1 year ago

adva-cisco commented 1 year ago
image

Thanks

adva-cisco commented 1 year ago

I'm adding a relevant mockup for the desired behaviour https://www.figma.com/file/XHENquLcsodYHHKb923uM1/Telescope?node-id=8962%3A99189&t=AePk6L4OCCTjGCKH-4

image

The tooltip of the timeline should be located above the name.

also, it could help if the timeline drag handle will be active across all the timeline, and not just the top.

image

Thanks

ophiryael commented 1 year ago

It is not a bug. It is a design decision. In regards to text, a tooltip can help in two main scenarios:

  1. The first is when we want to show some extra info about an element (e.g., when hovering over a "password" input and the tooltip shows the requirements for the password).
  2. The second scenario is what we have here when a text is overflowing. In many cases, the overflowing text will break its surrounding elements, a situation that a tooltip can solve. But our case is different. We can handle the overflow without breaking anything. I think tooltips should be avoided in the second case because they "relocate" the text from one place to another (from the original position to the tooltip). This text relocation makes it a bit harder to follow as the natural flow of the reading process is interrupted and starts again in a different location.

Of course, all of this is my opinion. It is not a bug. When implementing the timeline, I ensured it works as it works on Jaeger, as it makes much more sense. Let me know what you think (also, @maorlx, I assume you agree with @adva-cisco if you added it to the sprint).

maorlx commented 1 year ago

Closing as discussed and agreed to keep current behavior