search

telia-oss / github-pr-resource

Github pull request resource for Concourse
MIT License
182 stars 3 forks source link

Require image for ARM64 architecture #249

Open odidev opened 3 years ago

odidev commented 3 years ago

Hi Team, I am trying to use Github-pr-resource on ARM64 architecture but it seems ARM64 tag is not available in Docker Hub for the same.

I have tried using an automated build to push images to docker hub but it gave manifest error and I am not sure which CI you are using to push as it is not mentioned anywhere in the ReadMe document.

Do you have any plans to release an ARM64 image?

May I know how you are pushing images to Docker Hub?

I am able to build the arm64 image using Travis-CI. If you are interested in this, I can raise a PR.

odidev commented 3 years ago

It will be very helpful if an ARM64 image is released. Can I get any suggestions on which CI is being used to release images?

pratikbin commented 3 years ago

Hey @odidev, You can create your own one if you want I'm adding some resource below for compiling this in go for arm and creating image for arm, having arm device could smoothen the process. Hope it helps if not ping me

https://gist.github.com/truedat101/5898604b1f7a1ec42d65a75fa6a0b802 https://www.docker.com/blog/multi-arch-images/

rickardl commented 3 years ago

If you submit a PR adding this functionality, it's such a small change I wouldn't expect it to be any issues, but I would ask you to investigate how other concourse resources organise their Dockerfiles, if they're basing it on a multiple architectures.

bgandon commented 3 months ago

The least to say is that running Concourse on an arm64 architecture is uncommon. But I understand perfectly that it may be a requirement for you!

Unfortunately, there is no hope that you get any further support here (#246 was 2+y ago).

But recent news is that the Cloud Foundry community is now maintaining a fork of this resource at cloudfoundry-community/github-pr-resource.

On our Concourse installation at Gstack, that one is working fine. Could you give a try and provide feedback there? We'd love to review a PR providing multi-arch build for the improved Dockerfile we have there!

_(the new resource is a drop-in replacement; you only have to switch telia-ossto cfcommunity in in the resource_types: declaration, i.e. specify repository: cfcommunity/github-pr-resource)_