search

telia-oss / github-pr-resource

Github pull request resource for Concourse
MIT License
182 stars 5 forks source link

Could the PR remain in branch instead of merged to master? #268

Open pivotal-bin-ju opened 3 years ago

pivotal-bin-ju commented 3 years ago

I tried to set integration_tool=checkout, but the branch code is still merged to master. I am wondering if there a way to leave the PR in the branch?

I know the old jtarchie works in this flavor, the new resource break our pipeline.

Thanks!

tremblaysimon commented 2 years ago

If you use a put step, you must use get_params to add integration_tool=checkout parameter otherwise it will be override by the implicit get step done after a put step.

It looks like this in one of my job: 

...
    - get: pull-request
    - put: pull-request
      params:
        status: pending
        path: pull-request
      get_params:
        integration_tool: checkout
...
bgandon commented 4 months ago

Glad you found an answer to your issue!

But this would also need an update in the docs, don't you think?

Recent news is that the Cloud Foundry community is now maintaining a fork of this resource at cloudfoundry-community/github-pr-resource.

On our Concourse installation at Gstack, that one is working fine. Could you give a try and submit a PR to the docs there?

_(the new resource is a drop-in replacement; you only have to switch telia-ossto cfcommunity in in the resource_types: declaration, i.e. specify repository: cfcommunity/github-pr-resource)_