telia-oss / github-pr-resource

Github pull request resource for Concourse
MIT License
182 stars 3 forks source link

Github status not updated for ignored paths #288

Open ejgreco opened 1 year ago

ejgreco commented 1 year ago

Hey there,

We are using the github-pr-resource quite heavily in our pipeline. We've come across an issue where the github status of checks where the path that is not valid is not being updated, stuck in expected state. For instance, we have this configuration:

resources:
- check_every: 5m
  name: pr_app
  source:
    access_token: TOKEN
    paths:
    - app/
    - gradle/
    repository: org/repo
  type: github-pr-resource

When a PR comes with files changed in the app/ and gradle/ folder, the tests run and statuses are updated. But if a PR runs with files changed in other folders, the statuses stay in the expected state.

The same is also true for the ignore_paths config as well:

resources:
- check_every: 5m
   name: ignore_paths_app
   source:
     access_token: TOKEN
     ignore_paths:
     - app/
     repository; org/repo
  type: github-pr-resource

If files changed on a PR are in the app/ folder, the statuses are not updated. If any other folder is changed, it runs fine.

I've tried destroying and recreating the pipeline from Concourse yml. I looked at the logs for Concourse but these jobs that are supposed to sjipdon't even exist in the logs when they're missed. I've also tried renaming the resource, then reverting to the original name since the current resource names are intertwined in our build scripts. I also version bumped our usage of the github-pr-resource from v0.21.0 to v0.23.0.

Any help is appreciated!

bgandon commented 3 months ago

I don't have an answer for the issue you're encountering, sorry.

But unfortunately, there is also no hope that you get any support here (#246 was 2+y ago).

But recent news is that the Cloud Foundry community is now maintaining a fork of this resource at cloudfoundry-community/github-pr-resource.

On our Concourse installation at Gstack, that one is working fine. Could you give a try and provide feedback there?

_(the new resource is a drop-in replacement; you only have to switch telia-ossto cfcommunity in in the resource_types: declaration, i.e. specify repository: cfcommunity/github-pr-resource)_