search

telia-oss / terraform-aws-concourse

A Terraform module for deploying Concourse CI.
https://registry.terraform.io/modules/telia-oss/concourse/aws
MIT License
20 stars 11 forks source link

Add support for resolving parameters from AWS SSM credential manager #46

Open pinfoldd opened 4 years ago

pinfoldd commented 4 years ago

Feature request

How can we improve the module?

Add support for resolving parameters from AWS SSM credential manager.

Would adding this line work?

Environment="CONCOURSE_AWS_SSM_REGION=${region}"

here: https://github.com/telia-oss/terraform-aws-concourse/blob/master/modules/cloud-init/atc.yml#L49

itsdalmo commented 4 years ago

Hey @pinfoldd!

Assuming you are thinking of using parameter store as the secret backend for concourse, then yes your suggestion should work (this module used to do that). But you'd need to make it configurable, since I believe Concourse does not support multiple secret backends yet I think? 🤔