telia-oss / terraform-aws-ecs-fargate

Terraform module which creates Fargate ECS resources on AWS.
https://registry.terraform.io/modules/telia-oss/ecs-fargate/aws
MIT License
82 stars 75 forks source link

Should consider more than one task image #33

Closed chenrui333 closed 2 years ago

chenrui333 commented 4 years ago

Feature request

How can we improve the module?

Right now the task image only supports one container image.

lobsterdore commented 3 years ago

A way to achieve this would be to allow the task definition to be supplied by the caller, with a fallback to the current built in one.

larstobi commented 3 years ago

Good idea.

larstobi commented 3 years ago

We have a POC of this. Will create a PR.

phidah commented 2 years ago

We have a POC of this. Will create a PR.

Hi Lars. Any update on this? In our case the use-case would be to have a Datadog agent running as a sidecar container.

larstobi commented 2 years ago

@phidah Would something like #61 be sufficient?

larstobi commented 2 years ago

Fixed by #65