search

telia-oss / terraform-aws-ecs-fargate

Terraform module which creates Fargate ECS resources on AWS.
https://registry.terraform.io/modules/telia-oss/ecs-fargate/aws
MIT License
82 stars 75 forks source link

Add conditional container_port for service registry for A records #42

Closed larstobi closed 3 years ago

larstobi commented 3 years ago

Fixes issue where no SRV record in service disvocery dns config causes the service_registries block in the aws_ecs_service resource to fail because it does not accept container_port parameter.

jmickle commented 3 years ago

LGTM

jmickle commented 3 years ago

@larstobi LGTM that should work in place of the removal, assuming that AWS api continues to drop nulls and doesn't decide to do something wonky later down the line and err on nulls

larstobi commented 3 years ago

Good to hear! I think it's actually Terraform that interprets null as no parameter given. https://www.terraform.io/docs/configuration/expressions/types.html#null

jmickle commented 3 years ago

awesome, can we get this merged over to main?

larstobi commented 3 years ago

@jmickle released in https://github.com/telia-oss/terraform-aws-ecs-fargate/releases/tag/v3.5.1

jmickle commented 3 years ago

<3 got another PR coming for you for EFS vols in just a few