WIP: Support EFS volume mounts Request for Review for changes before finalization

telia-oss / terraform-aws-ecs-fargate

Terraform module which creates Fargate ECS resources on AWS.

https://registry.terraform.io/modules/telia-oss/ecs-fargate/aws

MIT License

82 stars 75 forks source link

WIP: Support EFS volume mounts Request for Review for changes before finalization #43

Closed jmickle closed 3 years ago

jmickle commented 3 years ago

Came across an incredibly annoying situation where building a prometheus cluster I was required to use an ECS service discovery plugin from teralytics. This requires a shared EFS volume on the ECS containers. This is a shi*tty first start (but working) at adding EFS support into the module. Terraform makes it an incredible PITA. Do me a favor and review it and leave your comments for how I can clean this up. Would be happy to make any changes or do it any better way you can think of.

larstobi commented 3 years ago

Are you getting good performance from Prometheus with EFS as storage?

We have switched to using EC2 for Prometheus because of access to an EBS disk.

However, now waiting for the Amazon Managed Prometheus Service terraform resource to be available. There is a PR waiting to be merged.

larstobi commented 3 years ago

Closed in favour of #53