EFS volumes

[feraudet]

Add:

• efs_volumes var
• Dynamic volume block to aws_ecs_task_definition based on efs_volumes
• An exemple in examples/basic/main.tf

[larstobi]

Thanks for the PR!

Have you tested it on a clean branch?

I wonder if a security group and rule for EFS might be needed? Like specified in #43.

Also, does it not need a mountPoints entry in the container definition?

[feraudet]

Security-group is not needed with fargate thanks to the IAM authorization. But yes, the mount point is missing, I will fix it then test it on a fresh branch

[feraudet]

• I added mountpoints in the container_definitions
• I tested the whole basic on a fresh branch It would be ok now

[larstobi]

Very nice, @feraudet !

Did you see my comment on the variable specification for efs_volumes ?

[feraudet]

I did not see it. Here an additional commit with specs

[larstobi]

Nice work, @feraudet !

Is the change to make lb_arns optional necessary for EFS support? If it's not necessary, I think it should be taken out and added in a separate PR. We do want the optional lb_arns feature, though! I've use for it myself, and have done the same with a local copy when needed. And please add a new folder in the examples directory with a name like "no-lb" or similar, where the example with no lb is shown.

We would like to keep the basic example as basic as possible. Please copy the basic folder in the example directory to a new folder called "efs" and check it in, and revert the basic example.

Otherwise, it looks great and soon ready for merge.

[larstobi]

The target group fix can be removed in this PR in favour of #59

[feraudet]

Nice work, @feraudet !

Is the change to make lb_arns optional necessary for EFS support? If it's not necessary, I think it should be taken out and added in a separate PR. We do want the optional lb_arns feature, though! I've use for it myself, and have done the same with a local copy when needed. And please add a new folder in the examples directory with a name like "no-lb" or similar, where the example with no lb is shown.

We would like to keep the basic example as basic as possible. Please copy the basic folder in the example directory to a new folder called "efs" and check it in, and revert the basic example.

Otherwise, it looks great and soon ready for merge.

No it's not needed, I created a separate PR about this feature after cause of this. I will revert this commit. I will add a "no-lb" example