telia-oss / terraform-aws-ecs-fargate

Terraform module which creates Fargate ECS resources on AWS.
https://registry.terraform.io/modules/telia-oss/ecs-fargate/aws
MIT License
82 stars 75 forks source link

add an option for the Task definition revision to not be deleted #77

Closed yuvalberk closed 1 year ago

yuvalberk commented 1 year ago

Feature request

Hello, as of now every time you update the task definition the previous revision is being deleted. I believe some people will want to save it for source control purposes, is it possible to give the user an option whether to delete it or not?

Thanks!

larstobi commented 1 year ago

The task definitions are not in fact deleted, but inactivated. So your requirement should already be met. There is also no option that I could find to set it as active or inactive. https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/ecs_task_definition#argument-reference

You can view the inactive task definitions in the Console.