search

telia-oss / terraform-aws-static-site

Terraform module for creating a static site using S3 and Cloudfront
MIT License
4 stars 12 forks source link

Replace with cloudposse/cloudfront-s3-cdn? #7

Open holyjak opened 4 years ago

holyjak commented 4 years ago

Deprecate this module and use the maintained https://registry.terraform.io/modules/cloudposse/cloudfront-s3-cdn/aws/ instead? It requires you creating the ACM certificate manually but is much more configurable. V 0.9+ supports TF 0.12.

itsdalmo commented 4 years ago

@colincoleman and @glennbech I guess. What do you guys think?

mikael-lindstrom commented 4 years ago

@holyjak @itsdalmo Should we continue and deprecate this module so we can close this issue?

holyjak commented 4 years ago

I guess so?

On Sun, 9 Feb 2020, 13:07 Mikael Lindström, notifications@github.com wrote:

@holyjak https://github.com/holyjak @itsdalmo https://github.com/itsdalmo Should we continue and deprecate this module so we can close this issue?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/telia-oss/terraform-aws-static-site/issues/7?email_source=notifications&email_token=AAEYSPXAPD6IW42KKZ6VGR3RB7WWVA5CNFSM4JA264Q2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELGKPIA#issuecomment-583837600, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEYSPXMVBJQNVYWNIL2WADRB7WWVANCNFSM4JA264QQ .

colincoleman commented 4 years ago

The cloudposse module looks very complete. But it does have dependencies on other cloudposse modules. I have a preference for forking 3rd party open source code that I use for production systems and that doesn't really work with modules that have dependencies on other modules (you would need to update your own forks to reference the forks of the dependencies...) Are there any specific features that this module is missing?