search

telkins / laravel-dag-manager

A SQL-based Directed Acyclic Graph (DAG) solution for Laravel.
MIT License
32 stars 9 forks source link

Add support for Laravel 9 #17

Closed gbuckingham89 closed 2 years ago

gbuckingham89 commented 2 years ago

This PR adds support for Laravel 9 but expanding the version constraints in composer.json.

The test suite is passing when run with Laravel 9.

telkins commented 2 years ago

@gbuckingham89 Thx for this. Much appreciated. I've got an L8 project that needs to move to L9 that uses this package. I've known I need to get this done and I haven't yet had the time....so, again, your contribution is definitely appreciated.

It all looks good. The only thing I need is to get the tests to run agains L9. If no one beats me to it, then I'll get that added to the test configuration and, assuming all passes, then it will be merged. As I noted in your other PR (#18 ), I hope to get some time by this weekend.

Thanks again...! 👍

telkins commented 2 years ago

@gbuckingham89 Sorry....I tried to make a few modifications to your PR and failed left, right, and center. I'm not really feeling well today, which is why I had some time, but it's also why I can't focus like normal. I tried the gh CLI, codespaces, and local "traditional" editing. In the end, I believe I got your changes with a few modifications, but how it all came together is a mystery to me. 😅

I'll have to take a look at what I did when I'm feeling better...and hope I didn't wreck everything.

I doubt I'll be able to get to your other PR until I'm back near 100%...but at least this one seems to be done.

Thx again...! 🚀