Open dealense7 opened 1 year ago
Thx for your input. It looks like you have identified a few things that need to be addressed. I just noticed and responded to your PR, which appears to fix at least one of the issues you mentioned. As noted in the PR conversation, I will try to get to that soon...as well as the other issues that you described.
Hello, In this commit https://github.com/telkins/laravel-dag-manager/commit/2503b6004ddd43449e7e691158264f43e54e83b8 , you have changed
getTable
togetTableName
. But if an user will create tables with different name in this methodprotected function edgeExists(): bool
dagEdgeModel
will try to get table by class name. So you need to addgetTable
method to the model as it is described in Laravel API . Also as I thinkgetTableName
has no usage. And one more thing, you haveedge_model
in config but your methods, for exampleprotected function createEdge(): DagEdge
as you see returnsDagEdge
model and not contract or something like that.Thank you!