search

telkins / laravel-dag-manager

A SQL-based Directed Acyclic Graph (DAG) solution for Laravel.
MIT License
32 stars 9 forks source link

getTableName in DagEdge model #22

Open dealense7 opened 1 year ago

dealense7 commented 1 year ago

Hello, In this commit https://github.com/telkins/laravel-dag-manager/commit/2503b6004ddd43449e7e691158264f43e54e83b8 , you have changed getTable to getTableName. But if an user will create tables with different name in this method protected function edgeExists(): bool dagEdgeModel will try to get table by class name. So you need to add getTable method to the model as it is described in Laravel API . Also as I think getTableName has no usage. And one more thing, you have edge_model in config but your methods, for example protected function createEdge(): DagEdge as you see returns DagEdge model and not contract or something like that.

Thank you!

telkins commented 1 year ago

Thx for your input. It looks like you have identified a few things that need to be addressed. I just noticed and responded to your PR, which appears to fix at least one of the issues you mentioned. As noted in the PR conversation, I will try to get to that soon...as well as the other issues that you described.