tellae / bhepop2

Synthetic population enrichment from aggregated data
https://bhepop2.readthedocs.io/en/latest/
Other
2 stars 1 forks source link

Modality specification in analysis functions #36

Closed leo-desbureaux-tellae closed 7 months ago

leo-desbureaux-tellae commented 11 months ago

When performing an analysis of the enrichment results (for instance using _analyse_enrichedpopulations) , we provide a dict of modalities.

This is not consistent with the enrichment classes taking a list of attributes and inferring the modalities from the distributions. In the other hand, this allows performing the analysis on a subset of modalities.

We should allow specifying a subset of modalities, but the complete set should be defined as in the enrichment classes.

This highlights some preprocessing duplication between enrichment and analysis. One way to avoid such duplication and ensure parameters consistency would be to call analysis from the enrichment class.

PierreOlivierVandanjon commented 11 months ago

But if analyse_enriched_population is independent from the enrichment class, it can be used to analyze other solutions. For example, in our papers, we compare our solutions with solutions easier to compute in order to show the interest and the limit of the proposed methodology. To be discussed