search

tellapart / aurproxy

Load balancer manager with knowledge of Apache Aurora's service discovery mechanism and integration with Aurora's task lifecycle.
Apache License 2.0
71 stars 18 forks source link

Allow --config to load from file:// locations #30

Closed benley closed 8 years ago

benley commented 8 years ago

Does this look like a reasonable idea? If so I'll also update the docs to match.

ThanosBaskous commented 8 years ago

I think that's fine, and if you update the docs as well, I'll be happy to merge.

My original thought was to force all configuration to live at the command line so that it is easily discoverable / diffable through the Aurora web interface and API. I suppose the same thing could be accomplished with a "config generator" aurora process that writes the file before the aurproxy_setup or aurproxy Aurora processes are started.

Anyways, that's not a constraint that's necessary to impose on everyone that uses this tool, so I'm fine with the change.

Thanks for contributing!

benley commented 8 years ago

Updated the --help text, but I didn't see a great place for this tidbit in README.md.

ThanosBaskous commented 8 years ago

:+1:

benley commented 8 years ago

:D