teller-protocol / teller-protocol-v1

Teller is a lending and undercollateralized borrowing protocol on the Ethereum blockchain. Teller is the first protocol to allow zero collateral borrowing for greater than one block.
https://teller.finance/
MIT License
106 stars 38 forks source link

[PROTOCOL-953] Take Out Loan V3 #480

Closed elclandestin0 closed 3 years ago

elclandestin0 commented 3 years ago

Given that the user has a combination of V1 and V2 tokens, we need to combine both NFT ID types to take out a loan. It doesn't make sense for a user to discriminate between a V1 and a V2 token when they are just trying to take out a loan.

An extra version # has been added in the CreateLoanWithNFTFacet.sol and the MainnetCreateLoanWithNFTFacet.sol. A new test has also been added in the loans.test.ts and the helper function for takeOutLoanWithNFTs is updated with the new case: 3