search

tellerhq / beta-issues

Issues, feedback and feature requests.
1 stars 0 forks source link

UX: pagination on transactions #2

Closed sebinsua closed 4 years ago

sebinsua commented 8 years ago

Currently the pagination is a page number and a count.

A very common use case for financial apps will be show me transactions from from until to datetimes.

It'd be good to get support for this.

stevegraham commented 7 years ago

Working on changing the pagination to before and after. I want these to be able to accept a transaction uuid, or a ISO8601 date, e.g. "2017-03-01". What do you think?

sebinsua commented 7 years ago

Working on changing the pagination to before and after.

Sounds good. I'd prefer an ISO8601 date though. What would the application be of accepting transaction ids? You would have to know one to query, surely?

stevegraham commented 7 years ago

It's for basic pagination, the pagination param for the next page would be the last of of the current page. It's better than the current implementation because if new transactions are inserted at the beginning of the collection it won't affect your pagination.

The idea is to support both dates and ids anyway.

Sent from my iPhone

On 1 Mar 2017, at 17:42, Seb Insua notifications@github.com wrote:

Working on changing the pagination to before and after.

Sounds good. I'd prefer an ISO8601 date though. What would the application be of accepting transaction ids? You would have to know one to query, surely?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

sebinsua commented 7 years ago

It's for basic pagination, the pagination param for the next page would be the last of of the current page. It's better than the current implementation because if new transactions are inserted at the beginning of the collection it won't affect your pagination.

Ah, that makes sense. Now I know why Twitter also uses ids for its pagination...