Open vetsin opened 2 months ago
Looks great as a start, some feedback:
get
, put
, list
commands in configuration?
get: some-bin get -k {{KEY_PATH}}
put: some-bin put -k {{KEY_PATH}} -v {{VALUE}}
list: some-bin list
This can allow people to more extensively customize how they run their custom binaries. A custom binary can be some app like 1password
or it can be just some shell script they made.
I believe some thought should be made to the "protocol" where the command returns results. Is it in JSON? what would be the shape of it?
-k
and -v
flags instead of positional arguments, though what's the benefit? It seems it would just make writing the script or binary harder, since you have to parse flags not not just a #!/bin/sh
with $2
and $3
How about just:
struct Credential {
path: String,
key: String,
value: String,
}
You're correct on -k
and -v
, it would indeed require someone to have a concept of a parser or use a parsing library. your suggestion sounds good.
For the Credential
struct, it sounds good as well, a few notes:
KV
(for key-value, since some secrets can be (a) just configuration settings (b) not secrets but confidential)
A mockup for #280.
Any external provider should manage it's own auth, e.g. maybe it will use
/var/run/secrets/kubernetes.io/serviceaccount/token
Looking for feedback on this idea/code.
Questions:
exec
?external
!=exec