tellomichmich / PokeNoxBot

Slow but safe Pokemon GO Bot
23 stars 19 forks source link

Does not correctly detect end of fight and reboot game #34

Closed Bolo30 closed 8 years ago

Bolo30 commented 8 years ago

Hi,

When pokemon is caugh the script does not correctly detect and reboot game :

[+] #STRESS... [+] #STRESS... [+] #STRESS... [#] Mmmm, something really strange happened ! [+] Looking for pokemon [!] LAST HOPE TO ESCAPE ! [#] Don't know where we are.... Exiting [!] Restarting the whole game !

If pokemon flee there is the same behaviour but not enough long to reboot game : [+] #STRESS... [+] #STRESS... [+] #STRESS... [#] Mmmm, something really strange happened ! [+] Looking for pokemon [+] No more Pokemon not found.

Next to this message the screenshot of game when script bug and does not detect pokemon caugh (then reboot game)

bug

I can see that the "ocr.png" and "ocr.txt" does not update after pokemon caugh, and stay on the value at the begining of the fight (so it's the number of selected pokeball left at the begining).

tellomichmich commented 8 years ago

Thank's for you review again ! How many "#STRESS" have you got ?

Bolo30 commented 8 years ago

Exemple with a pidgey the script just catch :

[*] Seems to be a Pidgey at 10 [+] 66 Poke Ball left [+] Throwing a Poke Ball (432) [+] #STRESS... [+] #STRESS... [+] #STRESS... [+] #STRESS... [+] #STRESS... [+] #STRESS... [+] #STRESS... [+] #STRESS... [+] #STRESS... [+] #STRESS... [+] #STRESS... [+] #STRESS... [+] #STRESS... [+] #STRESS... [+] #STRESS... [+] #STRESS... [+] #STRESS... [+] #STRESS... [+] #STRESS... [+] #STRESS... [+] #STRESS... [+] #STRESS... [+] #STRESS... [+] #STRESS... [+] #STRESS... [+] #STRESS... [+] #STRESS... [+] #STRESS... [+] #STRESS... [+] #STRESS... [#] Mmmm, something really strange happened ! [+] Looking for pokemon [!] LAST HOPE TO ESCAPE ! [#] Don't know where we are.... Exiting [!] Restarting the whole game ! Events injected: 1

The OUT_FAIL.png :

out_fail

Ocr.png :

ocr

tellomichmich commented 8 years ago

Ok I understand your bug ! I will try to correct this !

Bolo30 commented 8 years ago

I tested to modify the line 443 with a value of 40, and it's seem to work !

   for i in range(40):
tellomichmich commented 8 years ago

Yes this a good patch, but the bug append because you have a power full PC. If someone have a more powerfull PC, the bug will append to him.. I going to use time.

Bolo30 commented 8 years ago

Ok i undestand, thank you for your analysis :-)

tellomichmich commented 8 years ago

New version to bugfix your bug :)

Bolo30 commented 8 years ago

it works like a charm with this new bugfix, you're the boss :-)

tellomichmich commented 8 years ago

Don't hesitate to bug report, with your configuration. You should have more bug than this one ! Pokestop opening, Pokestop spinning, Pokestop closing, Pokemon fight opening...