search

tellomichmich / PokeNoxBot

Slow but safe Pokemon GO Bot
23 stars 19 forks source link

When there is no pokeballs, we must wait 30 "virtual" throwing before script stop fight #35

Closed Bolo30 closed 8 years ago

Bolo30 commented 8 years ago

It is possible to have script stop fight when he find there is no pokeballs ? (it was the case in past with old release of script)

Thank you ^^

tellomichmich commented 8 years ago

This should be corrected is new version. `
...

    #Check if pokeball are left
    INFO_LOG("%d %s left" % (PokeBallLeft, SelectedPokeball))
    if PokeBallLeft == 0:
        if IsNoMorePokeBall() == True:
            WARNING_LOG("No more pokeball... leaving fight !")
            ClosePokemonFight()
            return None
        PokeBallLeft = GetPokeballLeft()

`

tellomichmich commented 8 years ago

Can you confirm that it's ok ?

Bolo30 commented 8 years ago

test in progress :)

Bolo30 commented 8 years ago

i have the same issue, but what is the modification ? in your first reply i can't find difference between the curent release of script ?!

tellomichmich commented 8 years ago

Can you give me log ?

tellomichmich commented 8 years ago

Maybe an idea... Can you give me a screenshot when no pokeball happened ?

tellomichmich commented 8 years ago

Are you using English Language ?

Bolo30 commented 8 years ago

my os is in french and i configured nox/android in english i'm doing screenshot to send you

tellomichmich commented 8 years ago

Ok thank's can you give me log too ?

Bolo30 commented 8 years ago

where can i find other log files ? (other than on screen log)

2016-08-21_204005 2016-08-21_204130

Actual config in script to check pokeball : 

    #Check if pokeball are left
    INFO_LOG("%d %s left" % (PokeBallLeft, SelectedPokeball))
    if PokeBallLeft == 0:
        if IsNoMorePokeBall() == True:
            WARNING_LOG("No more pokeball... leaving fight !")
            ClosePokemonFight()
            return None
        PokeBallLeft = GetPokeballLeft()
tellomichmich commented 8 years ago

OK, IsNoMorePokeBall seems to fail with you, don't know why... I committed a workaround for you ! Can you give me the log when this happen again with the new version ?

Bolo30 commented 8 years ago

ok trying the new version ^^

Bolo30 commented 8 years ago

It's ok now !

[+] Looking for pokemon [] Going to fight with 151 501 ! [+] Wait for Pokemon fight... [+] Wait for Pokemon fight... [+] Wait for Pokemon fight... [@] IsNoMorePokeBall (178,251,165) [] Seems to be a Pidgey at 77 [+] 0 Poke Ball left [@] IsNoMorePokeBall (178,251,165) [#] No more pokeball... leaving fight ! [#] This place is near a Gym ? [+] ~10719 Exp/h [+] Looking around... [+] Looking for Pokestop [+] No more Pokestop found. [+] Looking for pokemon

tellomichmich commented 8 years ago

Thank's, the error came from IsNoMorePokeball :) I committed a patch ! Thanks for all your bug report !

tellomichmich commented 8 years ago

Are you on Discord ?

Bolo30 commented 8 years ago

no but i can come/create an account :)