Sometimes "Clean inventory" does not clean Razz Berry - Githubissues

tellomichmich / PokeNoxBot

Slow but safe Pokemon GO Bot

23 stars 19 forks source link

Sometimes "Clean inventory" does not clean Razz Berry #41

Closed Bolo30 closed 8 years ago

Bolo30 commented 8 years ago

Hi,

Sometimes script does not drop Razz Berry, altough it is in "config.json" : "ItemToDropList" : ["Potion", "Super Potion", "Hyper Potion", "Revive", "Poke Ball", "Razz Berry", "Great Ball"],

2016-08-23_133413

2016-08-23_133414

tellomichmich commented 8 years ago

This bug is caused by input swipe which is not precise enough... We need to detect first item position by analyzing the screen...

Dodo111 commented 8 years ago

Probably part of this bug: the bot removed 3x lure modules from my inventory tonight! q_q

tellomichmich commented 8 years ago

OK, I will make this bug as maximum priority !

tellomichmich commented 8 years ago

I committed a patch. Waiting for your review.

Bolo30 commented 8 years ago

There is always some mistake with latest script :

drop

tellomichmich commented 8 years ago

"No enough Great Ball to drop" is normal, I don't want to drop great ball under 100. Do you want config for this ?

Bolo30 commented 8 years ago

I think it's better to only use config.json (and no special customisation).

In my case i have lot of Great Ball and lot of Ultra Ball, so i need to drop Great Ball :-)

Perhaps only do that with Ultra Ball and not with Great Ball

tellomichmich commented 8 years ago

I think it's better to only use config.json (and no special customisation).

Sometimes, I don't want to dev during 2 hours just for corner case...

Ok, I will change config !

tellomichmich commented 8 years ago

I committed a patch ! And you are thanked on Readme for all your reviews !

Bolo30 commented 8 years ago

Thank you very much, script is now working like a charm ! and great job on config.json we can perfectly customise ressource drop :-)

Closing this issue ^^