search

tellor-io / dataSpecs

Data specifications for oracle queries
16 stars 9 forks source link

ComboQuery #83

Closed themandalore closed 1 year ago

themandalore commented 1 year ago

required

why couldn't you? You would just return an array with the spot price answer, and then the string...

e.g. for the answer ( abi.encode([1, "myanswer"]) )

oraclown commented 1 year ago

required

why couldn't you? You would just return an array with the spot price answer, and then the string...

e.g. for the answer ( abi.encode([1, "myanswer"]) )

Oh, I see. Yeah, if decoding responses with multiple types on the Sol side is fine, then I think it all looks good

tkernell commented 1 year ago

I think this looks good. One possible improvement: why even include the queryIds array? We could save gas costs and only include the queryData array

tkernell commented 1 year ago

Looks good!