tellor-io / telliot-feeds

Telliot feeds
https://tellor-io.github.io/telliot-feeds
Other
24 stars 8 forks source link

Fix manual string query #752

Closed akremstudy closed 6 months ago

akremstudy commented 6 months ago

Summary

close #750 Added sub class for StringQuery ValueType to use the new method for encoding/decoding available in the current version of eth_abi.

Steps Taken to QA Changes

Added test using a good response value from here to check encoding/decoding.

Checklist

This pull request is:

Happy engineering!

0xSpuddy commented 6 months ago

@tkernell can you please verify that this looks good for decoding in solidity? if so, we can merge and close imo. https://mumbai.polygonscan.com/tx/0xdc8f3491948800ce41c91c54bd0afa44826db77ae52c196f527f26ab25356c99

tkernell commented 6 months ago

looks good!