Calculating time vars per request for anyblock, and cryptocompare

tellor-io / telliot

The main CLI tool to interact with the Tellor projects

MIT License

28 stars 30 forks source link

Calculating time vars per request for anyblock, and cryptocompare #496

Closed imaginebeingatcomputers closed 3 years ago

imaginebeingatcomputers commented 3 years ago

This removes the ExpandTimeVars functions, and instead calculates time vars conditionally for anyblock and cryptocompare. Timestamp variables are then added to the request instead of being expanded via env variables.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 1192036584

0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 6.036%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/tracker/index/index.go	0	1	0.0%
<!--	Total:	0	1	0.0%	-->

Totals
Change from base Build 1185808416:	0.02%
Covered Lines:	118
Relevant Lines:	1955

💛 - Coveralls

krasi-georgiev commented 3 years ago

This calculation is not right according to the AMPL documentation and it returns different results than their API, I think that TWAP should be calculated at the time of the request and not EOD or BOD, I messaged them in their discord, so will wait for their reply to confirm. just now almost all submitted values are again off by 2-3% compared to their API