search

telly / TLYShyNavBar

Unlike all those arrogant UINavigationBar, this one is shy and humble! Easily create auto-scrolling navigation bars!
MIT License
3.73k stars 426 forks source link

TabBarController in Navigation controller results to no nav bar collapsing #112

Closed radimhalfar closed 8 years ago

radimhalfar commented 8 years ago

I have a UITabBarController in UINavigationController. The Bar controller is RootVc of Navigation Controller and I want in childViewController use shyNavBar. But if I try, even if I pass the scroll view to TabBarController it doesn't work at all.

NavController -> TabBarController -> Tabs(Here to use framework). The ChildVC is ViewController with table and I am passing tableView to manager's scroll view property.

Language Swift

[EDIT] It works if I assign tab bars manager as childs and only as I come to screen on second time

[EDIT2] Please add to your guide, that the manager has to be assigned after the tableView is filled with data!

Mazyod commented 8 years ago

Thanks for the feedback. The library explicitly observes contentSize of the scrollView, so it doesn't need to be assigned after the data is filled. It should work as long as you assign the scrollView after you've hooked up your delegates, as mentioned in the docs.

Maybe I need to investigate more on this, but I'm sure it's not related to the tableView data not being filled.