search

telly / TLYShyNavBar

Unlike all those arrogant UINavigationBar, this one is shy and humble! Easily create auto-scrolling navigation bars!
MIT License
3.73k stars 427 forks source link

the lib is not working correctly with SVPullToRefresh #133

Closed lethanhclub closed 8 years ago

lethanhclub commented 8 years ago

I am using both SVPullToRefresh & TLYShyNavBar. But the pull to refresh function is not working anymore

nonamelive commented 8 years ago

I found that if you comment out the following code in TLYShyScrollViewController.m, it will work with SVPullToRefresh.

//        if (self.refreshControl == nil || [self.refreshControl isHidden]) {
//            [self.scrollView tly_setInsets:insets];
//        }
lethanhclub commented 8 years ago

you will get wrong contentInset after scrolling the table view with it

arielpollack commented 8 years ago

The issue here is that they enter an infinite loop of updating the scrollView's content size/inset. This partial stack trace is a crash log we're receiving, and the original crash log is 10 times longer (meaning it performed the same methods over and over again in a cycle) image