search

telly / TLYShyNavBar

Unlike all those arrogant UINavigationBar, this one is shy and humble! Easily create auto-scrolling navigation bars!
MIT License
3.73k stars 427 forks source link

calculateTotalHeightRecursively should return the current height, not the height when fully expanded #144

Closed ndrewh closed 8 years ago

ndrewh commented 8 years ago

Fixes #141.

floriankrueger commented 8 years ago

Hi, just wanted to catch up on this PR. We have the fix in production for more than a month now (via https://github.com/t089/TLYShyNavBar) and have had no issues so far. Would you consider merging it so that we can move back from the fork to the original repo? thank you!

Mazyod commented 8 years ago

Thanks for the fix and the confirmation. I'll test this today with better demo cases and merge. If all goes well, we'll have a new release, as well!

Mazyod commented 8 years ago

Seems legit! I will need to add new test cases to the demo later, to properly test everything, then hopefully make a new release

floriankrueger commented 8 years ago

Any updates on the release? We'd love to remove our fork and go back to the original repo 🙂